Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GSoC report for Harmonic Mixing Enhancements #356

Merged
merged 10 commits into from
Aug 24, 2024

Conversation

danferns
Copy link
Contributor

@danferns danferns commented Jul 2, 2024

This PR will add the report for my GSoC project "Harmonic Mixing Enhancements" (previously known as "Track Key / BPM Color Coding").

Preview

@daschuer
Copy link
Member

daschuer commented Jul 2, 2024

Nice, thank you.

This wording is changed to target interested / alpha users, and added a section to ask for testing.
@daschuer
Copy link
Member

daschuer commented Jul 3, 2024

As this is your first blog post, you need also add your avatar like it is done here: #355

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thank you.

@Eve00000
Copy link
Contributor

Eve00000 commented Jul 5, 2024

https://deploy-preview-356--mixxx-website.netlify.app/news/2024-07-05-gsoc-project-report-daniel-fernandes/

what I learned from ronso: 1st comment: Linking a preview :-)
I like it too

@daschuer
Copy link
Member

Thank you for the update.
What's you plan with it. Should we merge it after a final check?

@danferns
Copy link
Contributor Author

Yes, that sounds good to me! I just want to adjust the intro a little, and then I'm ready to have it merged after a final check.

@danferns
Copy link
Contributor Author

I'm ready now!

@Eve00000
Copy link
Contributor

Eve00000 commented Aug 19, 2024

This PR will add the report for my GSoC project "Harmonic Mixing Enhancements" (previously known as "Track Key / BPM Color Coding").

Preview

Daniel, can you change/update the preview-link please,;
on the bottom you can see the 'netify/mixxx-website/deploy-preview -> open the details in a new window -> browse to your news post (full readers version) -> copy the url -> edit the preview in your first post in this pr
Thank you

@danferns
Copy link
Contributor Author

Done, thank you for letting me know!


Firstly, I'd like to thank my mentor [Daniel Schürmann]({author}daniel-schurmann) for guiding me right from the very initial planning and brainstorming stages, and all the way to reviewing and getting the PRs merged. He made sure that I was never stuck on anything, and took great care that things go smoothly. He has been very helpful and supportive!

I'd like to thank [ronso0](https://github.com/ronso0) for his valuable design ideas and for guiding me with helpful feedback and testing during the code review. I'd also like to thank [Swiftb0y]({author}nikolaus-einhauser) for his valuable feedback and suggestions and for helping me make my code easier to read and efficient.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This reads really nice.
I merge it now to have a stable URL on our website and meet the GSoC deadline for a "Work Product Submission": https://developers.google.com/open-source/gsoc/help/work-product
In case of additional findings they can be fixed afterwards.

@daschuer daschuer merged commit fc10f49 into mixxxdj:website Aug 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants