-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.1 Release blogpost #344
Conversation
Thank you very much for this PR. |
You will find the complete list of changes here: Is it reasonable to list them all? Probably not. |
The link will be: |
Can you also take care to the pre-commit complains. It has found typos and trailing spaces. |
For all manual and website PRs, let's please add a preview link to the PR description as soon as CI has built it. (just did that) |
OK, I'm learning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just a quick first review.
This is very lengthy, I had trouble spotting the actual "news" (important fixes, changelog). Appreciate the call for help with translations! I'm open for "user stories" (new contributor experience) and a brief "what's going on" overview, though shouldn't these better go to a "guest post" or something? |
Co-authored-by: ronso0 <[email protected]>
I do understand what you mean, so the release info could be something like a twitter/x-post, all info could be in 100 characters. |
looks good to me, thanks! someone in charge of the release can do the final merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if this got a round of markdownlint before merge. It's not part of pre-commit
what kind of animal is a markdownlint? |
just set this to Draft so it'll be merged only after we polished the changelog, currently the categories and items don't match (at least the not the list in this PR) |
Okay, the changelog is sorted correctly https://github.com/mixxxdj/mixxx/blob/2.4/CHANGELOG.md Shouldn't we list only the highlights here? |
I'll update the list and then you can select which ones need to go .... the more items users see, the more they can understand that it takes time to correct bugs and add features. |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good from my side now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor fixup ;) whill I'll merge myself.
Thanks all involved here ❤️ |
the Download page hasn't been updated, yet |
preview:
https://deploy-preview-344--mixxx-website.netlify.app/news/2024-04-26-mixxx-2-4-1-released