Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4.1 Release blogpost #344

Merged
merged 56 commits into from
May 9, 2024
Merged

2.4.1 Release blogpost #344

merged 56 commits into from
May 9, 2024

Conversation

Eve00000
Copy link
Contributor

@Eve00000 Eve00000 commented Apr 23, 2024

@daschuer
Copy link
Member

Thank you very much for this PR.
For you first website contribution we always need an avatar icon from you and an entry in pelican.py
Like @JoergAtGithub has done here: https://github.com/mixxxdj/website/pull/341/files

@daschuer
Copy link
Member

daschuer commented Apr 24, 2024

You will find the complete list of changes here:
mixxxdj/mixxx#13169

Is it reasonable to list them all? Probably not.
Maybe we should list only a few an than link the changelog.

@daschuer
Copy link
Member

content/news/XXX-XX-XXX Outdated Show resolved Hide resolved
@daschuer
Copy link
Member

Can you also take care to the pre-commit complains. It has found typos and trailing spaces.

content/news/XXX-XX-XXX Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Apr 24, 2024

For all manual and website PRs, let's please add a preview link to the PR description as soon as CI has built it. (just did that)

@Eve00000
Copy link
Contributor Author

Eve00000 commented Apr 24, 2024

OK, I'm learning.
Now I can see there are line problems, Can you tell me how I can make an enter? /n or <br> or ....

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just a quick first review.

content/news/XXXX-XX-XX-mixxx-2-4-1-released.md Outdated Show resolved Hide resolved
content/news/XXXX-XX-XX-mixxx-2-4-1-released.md Outdated Show resolved Hide resolved
content/news/XXXX-XX-XX-mixxx-2-4-1-released.md Outdated Show resolved Hide resolved
@ronso0
Copy link
Member

ronso0 commented Apr 24, 2024

This is very lengthy, I had trouble spotting the actual "news" (important fixes, changelog).
That can probably be improved by adding some formatting (headers, proper list style).

Appreciate the call for help with translations!

I'm open for "user stories" (new contributor experience) and a brief "what's going on" overview, though shouldn't these better go to a "guest post" or something?

@Eve00000
Copy link
Contributor Author

I do understand what you mean, so the release info could be something like a twitter/x-post, all info could be in 100 characters.
"New update 2.4.1 with fixes, download at ...... "
But if we want to involve the Mixxx-ers (I want to use this term for all Mixxx-users, developers, ....) we need to give some info that is more than formal, some info that would change their idea of some geeks sitting behind a screen writing code the whole day long drinking coffee....
I think everybody can see the list imediately turning the mousewheel, but keeping them a little longer in the news with the mentioning of little stories/experiences tells a lot more than just new version ...
It connects.
And connection is what a community needs. Not just formal contact on forum/github/zulip,
we are all different but we share something that is valuable and important for us.
People want to know, so let's write about it.
'spreading the experience' and 'being proud' is important.

@ywwg
Copy link
Member

ywwg commented Apr 25, 2024

looks good to me, thanks! someone in charge of the release can do the final merge

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if this got a round of markdownlint before merge. It's not part of pre-commit

@Eve00000
Copy link
Contributor Author

It'd be nice if this got a round of markdownlint before merge. It's not part of pre-commit

what kind of animal is a markdownlint?

@ronso0 ronso0 marked this pull request as draft April 26, 2024 12:02
@ronso0
Copy link
Member

ronso0 commented Apr 26, 2024

just set this to Draft so it'll be merged only after we polished the changelog, currently the categories and items don't match (at least the not the list in this PR)

@ronso0
Copy link
Member

ronso0 commented Apr 26, 2024

just set this to Draft so it'll be merged only after we polished the changelog, currently the categories and items don't match (at least the not the list in this PR)

Okay, the changelog is sorted correctly https://github.com/mixxxdj/mixxx/blob/2.4/CHANGELOG.md
The list here needs to be updated accordingly.

Shouldn't we list only the highlights here?

@Eve00000
Copy link
Contributor Author

Eve00000 commented Apr 26, 2024

just set this to Draft so it'll be merged only after we polished the changelog, currently the categories and items don't match (at least the not the list in this PR)

Okay, the changelog is sorted correctly https://github.com/mixxxdj/mixxx/blob/2.4/CHANGELOG.md The list here needs to be updated accordingly.

Shouldn't we list only the highlights here?

I'll update the list and then you can select which ones need to go .... the more items users see, the more they can understand that it takes time to correct bugs and add features.

@Eve00000
Copy link
Contributor Author

done

@daschuer daschuer marked this pull request as ready for review May 8, 2024 22:21
@daschuer daschuer changed the title [draft] 2.4.1 Release blogpost 2.4.1 Release blogpost May 8, 2024
@daschuer
Copy link
Member

daschuer commented May 8, 2024

@ronso0 and @Swiftb0y Is your review still pending? I have just clicked through the release 2.4.1

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good from my side now

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor fixup ;) whill I'll merge myself.

content/news/XXXX-XX-XX-mixxx-2-4-1-released.md Outdated Show resolved Hide resolved
@daschuer
Copy link
Member

daschuer commented May 9, 2024

Thanks all involved here ❤️

@daschuer daschuer merged commit 63eeba0 into mixxxdj:website May 9, 2024
6 checks passed
@ronso0
Copy link
Member

ronso0 commented May 9, 2024

the Download page hasn't been updated, yet
I thought we do that first, then publish the release post?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants