Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.4 screenshots #324

Merged
merged 1 commit into from
Feb 14, 2024
Merged

2.4 screenshots #324

merged 1 commit into from
Feb 14, 2024

Conversation

ywwg
Copy link
Member

@ywwg ywwg commented Feb 12, 2024

pointing to main branch to get a preview

@ywwg ywwg changed the base branch from website to 2.4 February 12, 2024 17:34
@ywwg
Copy link
Member Author

ywwg commented Feb 12, 2024

pointing back to 2.4

@ronso0
Copy link
Member

ronso0 commented Feb 12, 2024

pointing to main branch to get a preview

Ha, that's the trick!

LGTM, though the "50%" previews can be much smaller, for me they're rendered at ~300x180 px and I can watch them for a few seconds being downloaded.

Tbh, while it may make sense to show the window title bar (now playing text), the white top bars are distracting.
I don't want you to take the screenshots again, so can we simply cut that off?

@ywwg
Copy link
Member Author

ywwg commented Feb 13, 2024

yup I can crop those

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

Only issue (and we can't do much about it) is that Shade looks shitty when scaled up.
The other screenshots are excellent.
image

@ronso0 ronso0 merged commit 5fdd0c1 into 2.4 Feb 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants