Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numark NS6II docs #687

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Numark NS6II docs #687

merged 2 commits into from
Dec 31, 2024

Conversation

Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Aug 3, 2024

This is the mapping documentation for mixxxdj/mixxx#11075. Please review as I don't know how much longer I can work on the mapping because my controller is starting to fall apart.

@Swiftb0y
Copy link
Member Author

Swiftb0y commented Aug 3, 2024

CC @acolombier since you were so kind to review the mapping.

@Swiftb0y
Copy link
Member Author

Swiftb0y commented Aug 3, 2024

Build fails because I'm depending on #685

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just skimmed it to see if it was easy to read. All good except the odd numbering n some places 👍

source/hardware/controllers/numark_ns6ii.rst Show resolved Hide resolved
@Swiftb0y Swiftb0y changed the base branch from 2.4 to 2.5 December 19, 2024 12:45
Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise!

source/hardware/controllers/numark_ns6ii.rst Outdated Show resolved Hide resolved
source/hardware/controllers/numark_ns6ii.rst Outdated Show resolved Hide resolved
source/hardware/controllers/numark_ns6ii.rst Show resolved Hide resolved
@Swiftb0y
Copy link
Member Author

done

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ronso0
Copy link
Member

ronso0 commented Dec 30, 2024

waiting for mixxxdj/mixxx#11075

@Swiftb0y
Copy link
Member Author

Thank you.

@ronso0
Copy link
Member

ronso0 commented Dec 31, 2024

Ah, there's no 'fixup-prevent-merge' hook in the manual repo.
Can you please squash the commits? Then this is ready to roll once the mapping is ready.

@Swiftb0y
Copy link
Member Author

Yup. Thank you.

@Swiftb0y
Copy link
Member Author

Done. Both PRs are ready.

@ronso0 ronso0 merged commit d746bc1 into mixxxdj:2.5 Dec 31, 2024
9 checks passed
@Swiftb0y Swiftb0y deleted the feat/numark-ns6ii branch December 31, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants