-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numark NS6II docs #687
Numark NS6II docs #687
Conversation
CC @acolombier since you were so kind to review the mapping. |
Build fails because I'm depending on #685 |
b1d5b90
to
3854ce3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just skimmed it to see if it was easy to read. All good except the odd numbering n some places 👍
3854ce3
to
87c2358
Compare
305d10b
to
4844a08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise!
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
waiting for mixxxdj/mixxx#11075 |
Thank you. |
Ah, there's no 'fixup-prevent-merge' hook in the manual repo. |
Yup. Thank you. |
3ed9473
to
72bdbbb
Compare
Done. Both PRs are ready. |
This is the mapping documentation for mixxxdj/mixxx#11075. Please review as I don't know how much longer I can work on the mapping because my controller is starting to fall apart.