Fixes and slight UI/documentation improvements #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
iamjazzar
reviewed
Jun 18, 2021
| @@ -4,7 +4,7 @@ experiments = function() { | |||
| $.post("/experiments/confirm_human/"); | |||
| }, | |||
| goal: function(goal_name) { | |||
| $.post("/experiments/goal/" + goal_name); | |||
| $.post("/experiments/goal/" + goal_name + "/"); | |||
There was a problem hiding this comment.
I think it's cleaner to use f-Strings
Suggested change
| $.post("/experiments/goal/" + goal_name + "/"); | |
| $.post(f"/experiments/goal/{goal_name}/"); |
There was a problem hiding this comment.
@iamjazzar This is JavaScript 😀. Good attempt, I almost released this.
PetrDlouhy
force-pushed
the
merge_all
branch
from
8cb9539 to
94c7e46
Compare
PetrDlouhy
force-pushed
the
merge_all
branch
4 times, most recently
from
623905c to
f61120c
Compare
PetrDlouhy
force-pushed
the
merge_all
branch
6 times, most recently
from
0872354 to
74b6f3e
Compare
The function did in fact return None, but the assertRaises was wrongly written, so it did not test that the function raises anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains #192 and some more edits:
confirm_humantemplatetag