Enabled upload of zip archive of multiple SRG XML files #512
+58
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanessuniq
added
V3.0
enhancement
Signed-off-by: Vanessa Fotso <[email protected]>
vanessuniq
force-pushed
the
498-allow-for-uploading-multiple-srg-files-at-once
branch
from
3306e55 to
3adfb6a
Compare
|
Is this PR ready for merge? |
| @@ -23,7 +23,7 @@ def self.from_mapping(benchmark_mapping) | |||
| title = benchmark_mapping.title.first rescue nil | |||
| version = "V#{benchmark_mapping.version.version}" \ | |||
| "#{SecurityRequirementsGuide.revision(benchmark_mapping.plaintext.first)}" rescue nil | |||
| release_date = SecurityRequirementsGuide.release_date(benchmark_mapping.plaintext.first) | |||
| release_date = SecurityRequirementsGuide.release_date(benchmark_mapping.plaintext.first) rescue nil | |||
There was a problem hiding this comment.
Using rescue nil suppresses all errors, which might hide issues that should be addressed. Suggestion: Handle specific exceptions or log the error for debugging purposes.
Suggested change
| release_date = SecurityRequirementsGuide.release_date(benchmark_mapping.plaintext.first) rescue nil | |
| release_date = SecurityRequirementsGuide.release_date(benchmark_mapping.plaintext.first) rescue StandardError => e; Rails.logger.error(e.message); nil |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature enhancement #498
Signed-off-by: Vanessa Fotso [email protected]