Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Git Resource Example #301

Merged
merged 20 commits into from
Dec 23, 2024
Merged

Advanced Git Resource Example #301

merged 20 commits into from
Dec 23, 2024

Conversation

Amndeep7
Copy link
Contributor

Remaining updates after #300

wdower and others added 5 commits December 12, 2024 14:41
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for mitre-saf-training ready!

Name Link
🔨 Latest commit 1d4decb
🔍 Latest deploy log https://app.netlify.com/sites/mitre-saf-training/deploys/6769d88da125aa00089d7c48
😎 Deploy Preview https://deploy-preview-301--mitre-saf-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 72 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@aaronlippold
Copy link
Member

we should also clean up the tar.gz in the class so it doesn't have the extra dirs etc.

@Amndeep7
Copy link
Contributor Author

we should also clean up the tar.gz in the class so it doesn't have the extra dirs etc.

added it as a task in the big list pr - fysa @p-oneil @aaronlippold

src/courses/advanced/05.md Show resolved Hide resolved
src/courses/advanced/05.md Show resolved Hide resolved
@aaronlippold
Copy link
Member

For this callout - I wonder if there is a way to wrap the 'good' one in a green box and the 'bad' one in a red box so it is really clear which one is the the correct one?

Perhaps also a 'green check' next to the good version and a 'red x' next to the bad version?

:::
::: warning
Note that we are passing in the profile directory to the --depends flag, and not the profile's libraries directory. In our example, it's:

:icon green_check

inspec shell --depends my_git

and not
:icon red_x

inspec shell --depends my_git/libraries

:::

Signed-off-by: Amndeep Singh Mann <[email protected]>
@Amndeep7
Copy link
Contributor Author

@aaronlippold I looked at several different options for how to do what you want and it doesn't seem like there's an easy way to do it since we're working with code blocks which have a lot of styling and special handling of their own. It basically comes down to either building a custom component or handwriting some css.

If I swapped to using the in-line code as opposed to the full codeblock, I was able to use attrs to apply css to that code snippet in what I think you want. It might be possible to use attrs against the full codeblocks but I wasn't able to figure it out. You can let me know if you like it not.

image

The biggest con with the in-line code snippet as opposed to the codeblock is that you can't one-click copy it, but then again we have the actual thing we want the user to copy above this in a proper codeblock so idk if we actually need the stuff inside the warning here to be codeblocks too.

wdower
wdower previously requested changes Dec 20, 2024
src/courses/advanced/05.md Outdated Show resolved Hide resolved
@wdower
Copy link
Contributor

wdower commented Dec 20, 2024

@aaronlippold I looked at several different options for how to do what you want and it doesn't seem like there's an easy way to do it since we're working with code blocks which have a lot of styling and special handling of their own. It basically comes down to either building a custom component or handwriting some css.

This is overkill for what we're doing IMO. If we're using CSS inside of Markdown we are doing something wrong. I think the sentence works just fine if we take out the little icons.

@Amndeep7
Copy link
Contributor Author

@aaronlippold I looked at several different options for how to do what you want and it doesn't seem like there's an easy way to do it since we're working with code blocks which have a lot of styling and special handling of their own. It basically comes down to either building a custom component or handwriting some css.

This is overkill for what we're doing IMO. If we're using CSS inside of Markdown we are doing something wrong. I think the sentence works just fine if we take out the little icons.

Reverted as requested

@Amndeep7 Amndeep7 dismissed wdower’s stale review December 23, 2024 21:43

Resolved his issues but dude's on a well-deserved break so he's not looking here

@Amndeep7 Amndeep7 merged commit 436d545 into main Dec 23, 2024
9 checks passed
@Amndeep7 Amndeep7 deleted the git_test branch December 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants