-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Git Resource Example #301
Conversation
Signed-off-by: Will <[email protected]>
Signed-off-by: Will <[email protected]>
Signed-off-by: Will <[email protected]>
Signed-off-by: Will <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
✅ Deploy Preview for mitre-saf-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Will <[email protected]>
Signed-off-by: Will <[email protected]>
we should also clean up the tar.gz in the class so it doesn't have the extra dirs etc. |
Signed-off-by: Shivani Karikar <[email protected]>
added it as a task in the big list pr - fysa @p-oneil @aaronlippold |
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
For this callout - I wonder if there is a way to wrap the 'good' one in a green box and the 'bad' one in a red box so it is really clear which one is the the correct one? Perhaps also a 'green check' next to the good version and a 'red x' next to the bad version? ::: :icon green_check inspec shell --depends my_git and not inspec shell --depends my_git/libraries ::: |
Signed-off-by: Amndeep Singh Mann <[email protected]>
@aaronlippold I looked at several different options for how to do what you want and it doesn't seem like there's an easy way to do it since we're working with code blocks which have a lot of styling and special handling of their own. It basically comes down to either building a custom component or handwriting some css. If I swapped to using the in-line code as opposed to the full codeblock, I was able to use attrs to apply css to that code snippet in what I think you want. It might be possible to use attrs against the full codeblocks but I wasn't able to figure it out. You can let me know if you like it not. The biggest con with the in-line code snippet as opposed to the codeblock is that you can't one-click copy it, but then again we have the actual thing we want the user to copy above this in a proper codeblock so idk if we actually need the stuff inside the warning here to be codeblocks too. |
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
This is overkill for what we're doing IMO. If we're using CSS inside of Markdown we are doing something wrong. I think the sentence works just fine if we take out the little icons. |
Signed-off-by: Amndeep Singh Mann <[email protected]>
Signed-off-by: Amndeep Singh Mann <[email protected]>
Reverted as requested |
Resolved his issues but dude's on a well-deserved break so he's not looking here
Remaining updates after #300