profile dev updates #283

aaronlippold · 2024-12-06T03:06:04Z

No description provided.

Signed-off-by: Aaron Lippold <[email protected]>

netlify · 2024-12-06T03:06:23Z

✅ Deploy Preview for mitre-saf-training ready!

Name	Link
🔨 Latest commit	`40ad023`
🔍 Latest deploy log	https://app.netlify.com/sites/mitre-saf-training/deploys/675beb44aa02e70008dc8b47
😎 Deploy Preview	https://deploy-preview-283--mitre-saf-training.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 79 (🔴 down 1 from production) Accessibility: 97 (no change from production) Best Practices: 92 (no change from production) SEO: 100 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Aaron Lippold <[email protected]>

Signed-off-by: Amndeep Singh Mann <[email protected]>

…es, and then what is each kind of update Signed-off-by: Amndeep Singh Mann <[email protected]>

Signed-off-by: Amndeep Singh Mann <[email protected]>

aaronlippold · 2024-12-12T19:06:50Z

src/courses/profile-dev-test/11.md


-4. **Use Vendor-Managed Standard Releases:** When setting up a test suite, prioritize using vendor-managed standard releases for software installations and baseline configurations. This should be the starting point for both 'vanilla' and 'hardening' workflows. This approach ensures that your initial and ongoing testing, hardening, and validation closely mirror the real-world usage scenarios of your end-users.
+<table>
+  <thead>


Why isn't this a markdown table?

cause markdown tables can't do headers on both the top and left hand sides at the same time properly. admittedly i hoped doing the html table syntax instead would make that better, but it doesn't seem altogether that different.

Signed-off-by: Amndeep Singh Mann <[email protected]>

…aining into profile-dev-updates

Signed-off-by: Amndeep Singh Mann <[email protected]>

aaronlippold

there are a few little things but I think this is good to go

Copilot

Copilot reviewed 13 out of 28 changed files in this pull request and generated 2 comments.

Files not reviewed (15)

src/courses/profile-dev-test/13.md: Evaluated as low risk
src/courses/profile-dev-test/19.md: Evaluated as low risk
src/courses/profile-dev-test/11.md: Evaluated as low risk
src/courses/profile-dev-test/10.md: Evaluated as low risk
src/courses/profile-dev-test/02.md: Evaluated as low risk
src/courses/profile-dev-test/07.md: Evaluated as low risk
src/courses/profile-dev-test/09.md: Evaluated as low risk
src/courses/profile-dev-test/16.md: Evaluated as low risk
src/courses/profile-dev-test/15.md: Evaluated as low risk
src/courses/profile-dev-test/12.md: Evaluated as low risk
src/courses/profile-dev-test/03.md: Evaluated as low risk
src/courses/profile-dev-test/05.md: Evaluated as low risk
src/courses/profile-dev-test/20.md: Evaluated as low risk
src/courses/profile-dev-test/04.md: Evaluated as low risk
src/courses/profile-dev-test/06.md: Evaluated as low risk

Comments suppressed due to low confidence (6)

src/courses/profile-dev-test/18.md:14

The phrase 'minimizing incorrect results' should be 'minimizing false results' to maintain consistency.

minimizing incorrect results.

src/courses/profile-dev-test/08.md:4

The word 'Secruity' is misspelled. It should be 'Security'.

title: Secruity Benchmarks vs Traditional Software

src/courses/profile-dev-test/14.md:26

The word 'hopfully' is misspelled. It should be 'hopefully'.

hopfully finding that the actual InSpec code from the previous benchmark is very close to the needed InSpec code for the same 'requirement' in the new Benchmark.

src/courses/profile-dev-test/14.md:24

[nitpick] The phrase 'Create a spreadsheet to track your requirement mappings during the alignment process' could be more specific. Suggest providing a concrete example or template for the spreadsheet.

Create a spreadsheet to track your requirement mappings during the alignment process.

src/courses/profile-dev-test/14.md:153

The phrase 'This control is Not Applicable to containers' should be 'This control is not applicable to containers' to maintain consistency in capitalization.

only_if('This control is Not Applicable to containers', impact: 0.0) {

src/courses/profile-dev-test/21.md:12

The word 'automatcally' should be 'automatically' and 'setting' should be 'settings'.

Each of the subsequent kitchen files will inherit the shared settings from this file automatlly and merge them with the setting in the child kitchen file.

Copilot · 2024-12-13T07:50:57Z

src/courses/profile-dev-test/14.md

+  tag nist: ['SI-11 b']
+  tag 'host'
+
+  only_if('This control is Not Applicable to containers', impact: 0.0) {


The phrase 'This control is Not Applicable to containers' should be 'This control is not applicable to containers' to maintain consistency in capitalization.

Suggested change

only_if('This control is Not Applicable to containers', impact: 0.0) {

only_if('This control is not applicable to containers', impact: 0.0) {

Copilot · 2024-12-13T07:50:57Z

src/courses/profile-dev-test/21.md

+  galaxy_ignore_certs: true
+  requirements_path: spec/ansible/roles/requirements.yml
+  requirements_collection_path: spec/ansible/roles/requirements.yml
+  ansible_extra_flags: <%= ENV['ANSIBLE_EXTRA_FLAGS'] %>


The variable 'ansible_extra_flags' should be enclosed in quotes to avoid potential issues with special characters.

Suggested change

ansible_extra_flags: <%= ENV['ANSIBLE_EXTRA_FLAGS'] %>

ansible_extra_flags: "<%= ENV['ANSIBLE_EXTRA_FLAGS'] %>"

Signed-off-by: Will <[email protected]>

wdower · 2024-12-13T08:00:51Z

src/courses/profile-dev-test/17.md

-The `converge` stage uses Ansible Playbooks from the Ansible Lockdown project to apply hardening configurations, specifically the RHEL8-STIG playbook, and RedHat managed containers.
+The `converge` stage applies system configurations using infrastructure as code (IaC) tools. This crucial stage transforms your environment from a base state to your desired configuration.
+
+::: info Let 'em cook


Signed-off-by: Will <[email protected]>

profile dev updates

e30efbb

Signed-off-by: Aaron Lippold <[email protected]>

github-actions bot added user beginner advanced guidance courses labels Dec 6, 2024

aaronlippold and others added 20 commits December 5, 2024 22:48

profile dev updates

5f0e727

Signed-off-by: Aaron Lippold <[email protected]>

Merge branch 'main' into profile-dev-updates

e802b42

Merge branch 'main' into profile-dev-updates

c911110

readme/pg 1

3043ac6

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 2

534686a

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 3

71489a9

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 4 and 5

f5573e8

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 6

31d8a3b

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 7

0acf0b8

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 8

dc6e632

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 9

8450322

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 9 - forgot to update title so it has a number

955f16b

Signed-off-by: Amndeep Singh Mann <[email protected]>

clarified language pg 9

28ceec6

Signed-off-by: Amndeep Singh Mann <[email protected]>

ahhhhhhhhh

43be27b

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 10

52d06c3

Signed-off-by: Amndeep Singh Mann <[email protected]>

forgot to close the code tabs

7d9e6a8

Signed-off-by: Amndeep Singh Mann <[email protected]>

slight reordering so that it's profile management, then profile updat…

769ee07

…es, and then what is each kind of update Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 12-14 - update types

357529a

Signed-off-by: Amndeep Singh Mann <[email protected]>

fix syntax

0f658f4

Signed-off-by: Amndeep Singh Mann <[email protected]>

Merge branch 'main' into profile-dev-updates

ecbbd6e

aaronlippold commented Dec 12, 2024

View reviewed changes

Amndeep7 added 2 commits December 12, 2024 22:04

all the test kitchen ones

2c6a8d7

Signed-off-by: Amndeep Singh Mann <[email protected]>

Merge branch 'profile-dev-updates' of https://github.com/mitre/saf-tr…

880411b

…aining into profile-dev-updates

Amndeep7 added 4 commits December 12, 2024 22:18

merge in main again?

1192489

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 23 - github

6251f30

Signed-off-by: Amndeep Singh Mann <[email protected]>

pg 24 - tips

592361a

Signed-off-by: Amndeep Singh Mann <[email protected]>

last few

11d1cd1

Signed-off-by: Amndeep Singh Mann <[email protected]>

Amndeep7 requested review from karikarshivani and wdower December 13, 2024 06:50

aaronlippold commented Dec 13, 2024

View reviewed changes

aaronlippold requested a review from Copilot December 13, 2024 07:49

Copilot AI reviewed Dec 13, 2024

View reviewed changes

module --> class, fixing weird indentation on code blocks

dd54750

Signed-off-by: Will <[email protected]>

wdower reviewed Dec 13, 2024

View reviewed changes

typo

40ad023

Signed-off-by: Will <[email protected]>

wdower approved these changes Dec 13, 2024

View reviewed changes

Amndeep7 merged commit 4cec77c into main Dec 13, 2024
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

profile dev updates #283

profile dev updates #283

aaronlippold commented Dec 6, 2024

netlify bot commented Dec 6, 2024 •

edited

Loading

aaronlippold Dec 12, 2024

Amndeep7 Dec 13, 2024 •

edited

Loading

aaronlippold left a comment

Copilot AI left a comment

Copilot AI Dec 13, 2024

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Copilot AI Dec 13, 2024

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

wdower Dec 13, 2024

	only_if('This control is Not Applicable to containers', impact: 0.0) {
	only_if('This control is not applicable to containers', impact: 0.0) {

	ansible_extra_flags: <%= ENV['ANSIBLE_EXTRA_FLAGS'] %>
	ansible_extra_flags: "<%= ENV['ANSIBLE_EXTRA_FLAGS'] %>"

profile dev updates #283

profile dev updates #283

Conversation

aaronlippold commented Dec 6, 2024

netlify bot commented Dec 6, 2024 • edited Loading

✅ Deploy Preview for mitre-saf-training ready!

aaronlippold Dec 12, 2024

Choose a reason for hiding this comment

Amndeep7 Dec 13, 2024 • edited Loading

Choose a reason for hiding this comment

aaronlippold left a comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Dec 13, 2024

Choose a reason for hiding this comment

Copilot AI Dec 13, 2024

Choose a reason for hiding this comment

wdower Dec 13, 2024

Choose a reason for hiding this comment

netlify bot commented Dec 6, 2024 •

edited

Loading

Amndeep7 Dec 13, 2024 •

edited

Loading