Finish xtask manifest subcommand
#714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
added
type: enhancement
j-lanson
force-pushed
the
jlanson/xtask-manifest-diff-site
branch
2 times, most recently
from
933488e to
48c9ab7
Compare
alilleybrinker
previously approved these changes
Dec 16, 2024
… files Signed-off-by: jlanson <[email protected]>
j-lanson
dismissed
alilleybrinker’s stale review
The merge-base changed after approval.
j-lanson
force-pushed
the
jlanson/xtask-manifest-diff-site
branch
from
48c9ab7 to
dbeb1c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#693 must be merged first.
Resolves #689 .
Using the DownloadManifestEntry vecs parsed from the GitHub release API, diffs with the local download manifest entries of a plugin to determine which need to be appended to the file, and does the appending.
Only deficiency is that I was unable to determine how to make the
KdlNodes print with indent=2 and insert underscores in large numbers.