fix: get proper version from download manifest and spawn with canonical path #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
added
type: bug
j-lanson
force-pushed
the
jlanson/fix-plugin-ver-and-spawning
branch
from
f2cbd04 to
44d7628
Compare
j-lanson
changed the title
…al path Discovered a bug in the entry selection process from the plugin's download manifest, such that the desired version was not checked and the first entry with a matching arch was returned. Additionally, downloaded plugin.kdl files have entrypoints that are relative to the parent dir, but Hipcheck core does not change working directory for the process so we don't find the right plugin binary. This commit prepends the proper plugin cache dir to PATH when resolving the binary to execute so that the `git` plugin's `git` binary will be found before the actual version control software. This commit also passes entrypoint args properly to the plugin's Command object. Signed-off-by: jlanson <[email protected]>
j-lanson
force-pushed
the
jlanson/fix-plugin-ver-and-spawning
branch
from
44d7628 to
2dae179
Compare
alilleybrinker
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a bug in the entry selection process from the plugin's download manifest, such that the desired version was not checked and the first entry with a matching arch was returned. Additionally, downloaded plugin.kdl files have entrypoints that are relative to the parent dir, but Hipcheck core does not change working directory for the process so we don't find the right plugin binary. This commit appends the working dir to the entrypoint binary and canonicalizes it so it can be resolved. The new implementation works but disallows the use of arguments in the entrypoint or use of docker containers. The spawning code will need to be addressed at greater length in a subsequent commit.