Aamohd/file based config #662
Conversation
aamohd
force-pushed
the
aamohd/file-based-config
branch
3 times, most recently
from
3c7b075 to
866ea2b
Compare
j-lanson
added
type: enhancement
hipcheck/src/cli.rs
Outdated
| long = "exec", | ||
| global = true, | ||
| help_heading = "Path Flags", | ||
| long_help = "Path to the exec file." |
There was a problem hiding this comment.
--> "Path to the execution config file"
hipcheck/src/cli.rs
Outdated
| @@ -296,6 +315,9 @@ impl CliConfig { | |||
| policy: std::env::current_dir() | |||
| .ok() | |||
| .map(|dir| pathbuf![&dir, "Hipcheck.kdl"]), | |||
| exec: env::current_dir() | |||
| .ok() | |||
| .map(|dir| pathbuf![&dir, "config/Config.kdl"]), | |||
hipcheck/src/executor.rs
Outdated
hipcheck/src/main.rs
Outdated
| )) | ||
| }; | ||
|
|
||
| let plugin_data = exec_config.unwrap().plugin_data; |
There was a problem hiding this comment.
Instead of unwrapping, change the function to return an ExitCode and use Shell::print_error() like cmd_setup() and cmd_check()
hipcheck/src/plugin/types.rs
Outdated
| @@ -160,6 +160,9 @@ pub struct PluginContext { | |||
|
|
|||
| /// The child process in which the plugin is running. | |||
| pub proc: Child, | |||
|
|
|||
| /// The size of the gRPC buffer | |||
| pub grpc_buffer: usize, | |||
There was a problem hiding this comment.
rename to grpc_query_buffer_size
|
As I mentioned in one of the requested changes, we shouldn't take I think the solution is that everyone developing on Hipcheck copies @alilleybrinker thoughts? or should the "config" folder be un-deprecated as a concept and use the resolution of the config dir to determine the expected location of the Exec.kdl file? |
|
@aamohd, you'll also have to rebase off of main and address the |
aamohd
force-pushed
the
aamohd/file-based-config
branch
3 times, most recently
from
7d0179a to
41690cf
Compare
Signed-off-by: Aisha M <[email protected]> feat: allow file-based executor Signed-off-by: Aisha M <[email protected]> ExecConfig and PluginConfig added fix: fix broken test Signed-off-by: Andrew Lilley Brinker <[email protected]> Config parsing enabled Code cleanup Exec Config added to CLI Signed-off-by: Aisha M <[email protected]> feat: allow file-based executor config Signed-off-by: Aisha M <[email protected]> Code cleanup Signed-off-by: Aisha M <[email protected]> feat: allow file-based executor Signed-off-by: Aisha M <[email protected]> feat: allow file-based executor Signed-off-by: Aisha M <[email protected]>
Signed-off-by: Aisha M <[email protected]>
aamohd
force-pushed
the
aamohd/file-based-config
branch
from
41690cf to
7b3f032
Compare
Signed-off-by: Aisha M <[email protected]>
Signed-off-by: Aisha M <[email protected]>
Signed-off-by: Aisha M <[email protected]>
No description provided.