Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Preparing to use 'dist' for more releases. #608

Merged
merged 1 commit into from
Dec 5, 2024
Merged

chore: Preparing to use 'dist' for more releases. #608

merged 1 commit into from
Dec 5, 2024

Conversation

alilleybrinker
Copy link
Collaborator

This relies on the upgrade to the latest version of 'dist'. Since we now have plugins that we want to produce pre-built binaries for, this updates our build configuration to support that. It'll need to be tested.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch 2 times, most recently from 8be06d2 to d42a187 Compare November 9, 2024 00:01
@alilleybrinker
Copy link
Collaborator Author

Update: The dist folks are investigating this error; trying to figure out why plan is complaining, which it shouldn't be doing.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch from d42a187 to 507768e Compare November 13, 2024 00:30
@alilleybrinker
Copy link
Collaborator Author

After some debugging, I was able to at least eliminate the duplication of packages found by cargo-dist. Turns out my workspace.members field in the dist-workspace.toml file was wrong; when including a Cargo virtual workspace with many distable packages in it, you only need to include the root, not each package individually.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch 3 times, most recently from 844f673 to 9887e88 Compare November 13, 2024 19:40
@alilleybrinker
Copy link
Collaborator Author

Update: cargo-dist team is working on resolving the bug that's blocking this PR. Basically, an internal setting called needs_coherence is being incorrectly set to true for cargo dist plan. Once the fix is out I'll update this to use the patched version of cargo-dist and we can proceed.

@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch from 9887e88 to b180fd0 Compare November 22, 2024 17:53
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch 2 times, most recently from e74e690 to 035baf8 Compare December 3, 2024 23:42
@alilleybrinker alilleybrinker self-assigned this Dec 3, 2024
@alilleybrinker alilleybrinker added the product: project Relates to the project itself label Dec 3, 2024
@alilleybrinker
Copy link
Collaborator Author

@j-lanson, this is now running a prerelease version of cargo-dist which incorporates the fixes for tag incoherence we've discussed. If all looks good to you, we can merge and then proceed with running a release for the new plugins!

j-lanson
j-lanson previously approved these changes Dec 4, 2024
View reviewed changes
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch 2 times, most recently from 764b5e1 to 0f7d659 Compare December 4, 2024 22:11
@alilleybrinker
chore: Preparing to use 'dist' for more releases.
cb35c34 
This relies on the upgrade to the latest version of 'dist'. Since
we now have plugins that we want to produce pre-built binaries for,
this updates our build configuration to support that. It'll need to
be tested.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/prep-dist branch from 0f7d659 to cb35c34 Compare December 4, 2024 22:51
@alilleybrinker alilleybrinker merged commit 37d1270 into main Dec 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-lanson j-lanson j-lanson approved these changes

Assignees

@alilleybrinker alilleybrinker

Labels
product: project Relates to the project itself
Projects
Hipcheck Dev Roadmap
Status: Done
Hipcheck Product Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alilleybrinker @j-lanson