Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFD - Plugin SDK #402

Merged
merged 1 commit into from
Sep 16, 2024
Merged

RFD - Plugin SDK #402

merged 1 commit into from
Sep 16, 2024

Conversation

alilleybrinker
Copy link
Collaborator

No description provided.

@alilleybrinker alilleybrinker added type: chore Clean up or management task. product: rust-sdk Relates to the Rust plugin SDK labels Sep 12, 2024
@alilleybrinker alilleybrinker self-assigned this Sep 12, 2024
@alilleybrinker alilleybrinker changed the title chore: WIP RFD for the plugin SDK RFD - Plugin SDK Sep 12, 2024
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/plugin-sdk-rfd branch 2 times, most recently from b1c3bd3 to d381aa7 Compare September 13, 2024 20:48
@alilleybrinker alilleybrinker marked this pull request as ready for review September 13, 2024 20:48
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/plugin-sdk-rfd branch 2 times, most recently from fcf7031 to 03d76bb Compare September 13, 2024 20:50
@alilleybrinker alilleybrinker added this to the 3.7.0 milestone Sep 13, 2024
@alilleybrinker alilleybrinker requested review from a team and cstepanian and removed request for a team September 13, 2024 20:50
@j-lanson j-lanson self-requested a review September 16, 2024 13:58
j-lanson
j-lanson requested changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@j-lanson j-lanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a few comments

@alilleybrinker
chore: Rust plugin SDK RFD
b6fea66 
This RFD describes the design of the API for the Rust plugin SDK, to be
used to help guide the team in implementing this API.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker alilleybrinker force-pushed the alilleybrinker/plugin-sdk-rfd branch from 03d76bb to b6fea66 Compare September 16, 2024 15:47
@alilleybrinker
Copy link
Collaborator Author

@j-lanson updated and ready for re-review

@j-lanson j-lanson self-requested a review September 16, 2024 15:53
@j-lanson j-lanson merged commit 0b42013 into main Sep 16, 2024
10 checks passed
@alilleybrinker alilleybrinker deleted the alilleybrinker/plugin-sdk-rfd branch September 16, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-lanson j-lanson j-lanson approved these changes

@cstepanian cstepanian Awaiting requested review from cstepanian cstepanian was automatically assigned from mitre/hipcheck-maintainers

Assignees

@alilleybrinker alilleybrinker

Labels
product: rust-sdk Relates to the Rust plugin SDK type: chore Clean up or management task.
Projects
Hipcheck Dev Roadmap
Status: Done
Hipcheck Product Roadmap
Status: Done
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@alilleybrinker @j-lanson