Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added primitive support for plugin downloading, decompression a… #316

Merged

Conversation

patrickjcasey
Copy link
Contributor

@patrickjcasey patrickjcasey commented Aug 30, 2024

This pull request adds the following:

  • Preliminary support for downloading, decompressing and unarchiving plugins into the HC_CACHE/plugins folder
  • Renamed several structs related to plugins to include Plugin as a prefix to avoid confusion
  • Removed hipcheck/plugin/parser, as it started to contain code that was outside of the scope of just KDL parsing

@patrickjcasey patrickjcasey force-pushed the patrickjcasey/plugin-download-decompress-unarchive branch from f27644b to 624ccd3 Compare August 30, 2024 18:09
@patrickjcasey patrickjcasey marked this pull request as ready for review August 30, 2024 18:11
Copy link
Contributor

@mchernicoff mchernicoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from the plugin structure side, but I'll wait to merge on @alilleybrinker taking a look too.

@alilleybrinker alilleybrinker merged commit 55fe6f5 into main Sep 3, 2024
9 checks passed
@patrickjcasey patrickjcasey deleted the patrickjcasey/plugin-download-decompress-unarchive branch September 6, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants