plugin Salsa integration #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
force-pushed
the
jlanson/plugin-salsa-integ
branch
from
7b4fc41 to
4e00e26
Compare
alilleybrinker
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This relies on PR #297 . Merge that one first.
This PR integrates the plugin querying infrastructure that has been built up by previous PRs into the salsa Database framework. The
HcEnginetrait andHcEngineImplstruct expose a (synchronous)query(publisher, plugin, name, key)interface, which accesses a globaltokioruntime to call theasync fns for invokingHcPluginCorefunctionality. Thequeryfunction is recursive, so the "stack" of query state is represented by actual stack frames.