feat: add proto-file based code gen #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
force-pushed
the
jlanson/proto-file-gen
branch
8 times, most recently
from
5031101 to
28f5b72
Compare
j-lanson
force-pushed
the
jlanson/proto-file-gen
branch
from
28f5b72 to
397ca5a
Compare
j-lanson
changed the title
alilleybrinker
requested changes
Aug 12, 2024
j-lanson
force-pushed
the
jlanson/proto-file-gen
branch
from
397ca5a to
22b7fca
Compare
alilleybrinker
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit to inject
hipcheck.proto-->hipcheck.rscode gen into our build process. Updated site install instructions, GitHub CI, and Containerfile to includeprotocinstall.Windows
protocinstall for GitHub CI is currently reliant on curling specific version, which will need to be updated over time. Assumingchocolateyis installed, could use this package instead. Site shows a few warnings about binaries included, so I was hesitant.