Include AWS resource name in code description in AWS Config Mapper #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkufro
force-pushed
the
aws_mapper_resource_names
branch
from
2aaad38 to
99da1b9
Compare
aaronlippold
approved these changes
Sep 20, 2021
Signed-off-by: Justin Kufro <[email protected]>
jkufro
force-pushed
the
aws_mapper_resource_names
branch
from
99da1b9 to
583dd15
Compare
|
There seems to be some linting errors ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times when the resource ID is not convenient enough to identify exactly which resource a test is referencing in the AWS Config Mapper. This PR makes another API call that queries for each resource name using the resource ID, and then includes that name in the code description attribute.