handle output readability better

mitre · Aug 5, 2024 · fb8203f · fb8203f
1 parent 4c07e73
commit fb8203f
Showing 1 changed file with 14 additions and 7 deletions.
diff --git a/libs/hdf-converters/src/msft-secure-score-mapper.ts b/libs/hdf-converters/src/msft-secure-score-mapper.ts
@@ -12,19 +12,21 @@ type ProfileResponse = {
   '@odata.context': string;
   '@odata.nextLink': string;
   value: SecureScoreControlProfile[];
-}
+};
 type SecureScoreResponse = {
   '@odata.context': string;
   '@odata.nextLink': string;
   value: SecureScore[];
-}
+};
 
 export class MsftSecureScoreMapper extends BaseConverter {
   withRaw: boolean;
-  rawData: {secureScore: SecureScoreResponse, profiles: ProfileResponse}
+  rawData: {secureScore: SecureScoreResponse; profiles: ProfileResponse};
 
   private getProfiles(controlName: string): SecureScoreControlProfile[] {
-    return this.rawData.profiles.value.filter((profile) => profile.id === controlName);
+    return this.rawData.profiles.value.filter(
+      (profile) => profile.id === controlName
+    );
   }
 
   mappings: MappedTransform<
@@ -64,7 +66,9 @@ export class MsftSecureScoreMapper extends BaseConverter {
                 if (titles.length > 0) {
                   return titles.join('\n');
                 } else {
-                  return `${data.controlCategory || ''}:${data.controlName || ''}`;
+                  return [data.controlCategory || '', data.controlName || '']
+                    .filter((title) => title)
+                    .join(':');
                 }
               }
             },
@@ -218,10 +222,13 @@ export class MsftSecureScoreMapper extends BaseConverter {
         return {
           auxiliary_data: [
             {
-              name: 'Microsoft Secure Score', 
+              name: 'Microsoft Secure Score',
               data: {
                 profiles: this.rawData.profiles,
-                secureScores: _.pick(this.rawData.secureScore, ['@odata.context', '@odata.nextLink'])
+                secureScores: _.pick(this.rawData.secureScore, [
+                  '@odata.context',
+                  '@odata.nextLink'
+                ])
               }
             }
           ],