Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tested python versions #39

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Update tested python versions #39

merged 1 commit into from
Oct 24, 2023

Conversation

clenk
Copy link
Contributor

@clenk clenk commented Oct 20, 2023

Description

Caldera no longer supports Python 3.7, and we should test 3.10 and 3.11 now.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Check the output of the github workflow.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

mchan143
mchan143 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@mchan143 mchan143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mchan143 mchan143 merged commit c4b14e2 into master Oct 24, 2023
6 checks passed
@mchan143 mchan143 deleted the clenk/update-test-harness311 branch October 24, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchan143 mchan143 mchan143 approved these changes

@uruwhy uruwhy Awaiting requested review from uruwhy

@elegantmoose elegantmoose Awaiting requested review from elegantmoose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clenk @mchan143