Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image to use official python image to pin python version #2762

Closed
wants to merge 0 commits into from

Conversation

pstarconsult
Copy link

Description

This is a PR as a direct response to the following issue mitre-atlas/arsenal#2. We have found that counterfit, one of the requirements for the plugin arsenal is incompatible with python 3.9 and above. The ubuntu base image as of the time of writing will install python 3.10 by default.

In general this could be problematic not only for this change but potentially for future versions as the ubuntu:latest base image will imply it will use the latest version of ubuntu (and hence python, and other things) which can cause breaking changes. Hence we propose to use python official image as our base image such that we are able to pin the python version to 3.8.

We confirmed that after applying this change and some minor typo fix in the arsenal repo (we could be opening another PR for the fix in the arsenal repo), we could successfully access arsenal in the containerized version of caldera. Also we did not face any other issues during image building and deployment.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

We have not run it with properly testing suite, please recommend the testing method for the containerized version of caldera.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant