-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
595 improved layer upgrade UI workflow #614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start towards improving the usability of the layer upgrade interface. I've noticed a few areas that could benefit from some minor adjustments, and I have a few recommendations which could further improve the UX to be more intuitive and user-friendly.
- There are some errors being thrown when the layer upgrade UI is loaded:
-
The "review all" button marks all techniques as reviewed and also automatically progresses to the next step which might be a bit confusing as its dual function isn't immediately intuitive; it would be more user-friendly if this was adjusted to only alter the "reviewed" status of techniques in the current step.
-
Placing the new buttons at the bottom of the wizard panel is a bit confusing as they are not related to the navigation between the layer upgrade steps, but rather changing the display of the current step. I would expect to find only navigation-related buttons at the bottom and any buttons/options related to the current steps above the technique panels.
-
I recommend changing the "review all" and "expand all" buttons to checkboxes, allowing users to easily toggle between reviewing/expanding all techniques and un-reviewing/collapsing them.
-
The current labels "review all" and "expand all" could be confusing as they both use the term "all" but have different scopes of action -"review all" affects all techniques in the step, while "expand all" only affects techniques on the current page of the paginated table. I'd recommend renaming to "mark all as reviewed" and "expand visible techniques" to clarify their functions.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR addresses #595.