-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TQ Compatible with Qiskit ≥1.0.0 #267
Make TQ Compatible with Qiskit ≥1.0.0 #267
Conversation
Hey, if you could take a look at the tests to get them functional, that would be amazing! Don’t worry about getting the lint and pre-commit working (they generally won’t pass), just get the Python package tests functional (which should essentially be the same thing from running Right now, it looks like there’s a small syntax error:
You may also need to change the extra dependencies in the workflow here. (We may actually be able to delete that line.) |
Thanks for being patient. I ran the tests and examples locally and they should be working now. |
Awesome, the PR functionally looks great! I’ll do a more thorough review later today then we can merge. Thanks so much! |
I’ll get to this ASAP, sorry about the delay! In the meantime though, could you comment on the issue so I can more easily assign you it? That is necessary for making sure you get the bounty at the end of Unitary Hack! |
Hi @GenericP3rson, it seems like there are still some places I have to change to merge the dev branch. Would you like to review the code first, or should I resolve the remaining compatibility issues first? |
Don't worry about it for now, I'm going to cherrypick the code that is failing out (since it's mostly density matrix code that isn't ready for the dev branch yet) and merge into the updated branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this looks good to me! One small note to relax the dependencies but otherwise will be good to merge!
Looks like I messed something up while rebasing — I’ll fix that up! |
Co-authored-by: Kazuki Tsuoka <[email protected]>
Co-authored-by: Kazuki Tsuoka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more instance of the unnecessary cloning.
Co-authored-by: GenericP3rson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good from my end!
Is TQ now compatible with qiskit>=1.1.0? |
Description
Resolve #262
Notes
qiskit.tools.job_monitor
has been removed from qiskit and there is no replacement (ref: Migration guides), so I just removed from the code.(I am contributing to this project as a unitaryHACK participant)