feat: add json schema for http-client.env.json #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `_base` to `$shared` and `DEFAULT_HEADERS` to `$default_headers`.
gorillamoe
force-pushed
the
feat/json-schemas
branch
from
e3fcc79
to
e874722
Compare
|
Maybe need some help for documenting the vscode stuff from @Grueslayer afterwards. I'll merge this as is, but let's discuss how we want to document this later, please 👍 |
gorillamoe
added a commit
to rcasia/kulala.nvim
that referenced
this pull request
Oct 7, 2024
* feat: add json schema for http-client.env.json * fix: allow $schema key * breaking(env): change `_base` to `$shared` Change `_base` to `$shared` and `DEFAULT_HEADERS` to `$default_headers`. * feat(schema): allow number * refactor(env): rename base to shared * fix(env): don't list special keys * feat(docs): add $schema to json example * chore(rename): add `.schema` as suffix. * chore(docs): change `_base` to `$shared`
iamxiaojianzheng
pushed a commit
to iamxiaojianzheng/kulala.nvim
that referenced
this pull request
Oct 24, 2024
* feat: add json schema for http-client.env.json * fix: allow $schema key * breaking(env): change `_base` to `$shared` Change `_base` to `$shared` and `DEFAULT_HEADERS` to `$default_headers`. * feat(schema): allow number * refactor(env): rename base to shared * fix(env): don't list special keys * feat(docs): add $schema to json example * chore(rename): add `.schema` as suffix. * chore(docs): change `_base` to `$shared`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.