-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Misskey Gamesのプレイ可否をロールで制限できるように #14955
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #14955 +/- ##
===========================================
+ Coverage 40.09% 41.63% +1.54%
===========================================
Files 1563 1567 +4
Lines 197741 203660 +5919
Branches 3632 3701 +69
===========================================
+ Hits 79277 84804 +5527
- Misses 117861 118283 +422
+ Partials 603 573 -30 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -76541,6 +76541,15 @@
}
}
},
+ "TARGET_IS_NOT_AVAILABLE": {
+ "value": {
+ "error": {
+ "message": "You or target user is not available due to server policy.",
+ "code": "TARGET_IS_NOT_AVAILABLE",
+ "id": "3a8a677f-98e5-4c4d-b059-e5874b44bd4f"
+ }
+ }
+ },
"INVALID_PARAM": {
"value": {
"error": {
@@ -81820,6 +81829,9 @@
},
"canImportUserLists": {
"type": "boolean"
+ },
+ "canPlayGames": {
+ "type": "boolean"
}
},
"required": [
@@ -81853,7 +81865,8 @@
"canImportBlocking",
"canImportFollowing",
"canImportMuting",
- "canImportUserLists"
+ "canImportUserLists",
+ "canPlayGames"
]
},
"ReversiGameLite": { |
Co-authored-by: syuilo <[email protected]>
Co-authored-by: syuilo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
プレイできないというより「ランキングに記録を残せない」方が良さそう(クライアントで完結してサーバーや他のユーザーに影響を一切与えないものを制限する必要はないと思われるため)
What
かいてあるとおり
Why
Fix #13111
Additional info (optional)
APIをガチガチにしてあるけどここまでやる必要があるかは謎
Checklist