Add shot block test cases #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for the false and default case have the same logic, suggesting that mpf-docs:docs/config/shot_profiles.md is out of date about default block behavior.
|
|
It looks like the three failures in linting are preexisting on dev |
avanwinkle
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been learning about shot blocking and I realized through testing that the MPF docs are incorrect (on https://github.com/missionpinball/mpf-docs/blob/main/docs/config/shot_profiles.md ) about the default behavior of Block.
In order to prove that the default behavior is as block: False instead of True, I've added test cases for the False and True options. (config_spec:1617 for shot_profiles:block shows the default to be false as well)