Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds getGroupDetails method and tests #3

Merged
merged 5 commits into from
Oct 17, 2017
Merged

Adds getGroupDetails method and tests #3

merged 5 commits into from
Oct 17, 2017

Conversation

ljewalsh
Copy link
Contributor

No description provided.

@stayradiated
Copy link
Contributor

What do you think about having two seperate functions:

  • getGroupStatsByName
  • getGroupStatsById

I'm just thinking that group and groupId are two ambiguous to use to know when to pass the group name or the group ID, and something like this might sneak in:

getGroupDetails({ group: '12345' })

@ljewalsh
Copy link
Contributor Author

that makes sense to me

@stayradiated stayradiated merged commit dfb27a9 into master Oct 17, 2017
@stayradiated stayradiated deleted the get-group-details branch October 17, 2017 00:15
@stayradiated
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljewalsh @stayradiated