fix: Make NEXT_PUBLIC_BUTTER_CMS_API_KEY optional #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karolkarolka
approved these changes
Dec 17, 2024
karolkarolka
requested changes
Dec 17, 2024
| @@ -1,3 +1,3 @@ | |||
| export type ButterCMSMenuServiceConfig = { | |||
| token: string; | |||
| token?: string; | |||
There was a problem hiding this comment.
token is required in infra but the infra shouldn't run without that env variable which can be undefined. It isn't necessary to run the storefront
There was a problem hiding this comment.
I updated cms service to throw an error if no token.
karolkarolka
requested changes
Dec 17, 2024
packages/infrastructure/src/public/butter-cms/cms-page/types.ts
Outdated
Show resolved
Hide resolved
packages/infrastructure/src/public/butter-cms/cms-menu/types.ts
Outdated
Show resolved
Hide resolved
karolkarolka
approved these changes
Dec 17, 2024
soniaklimas
deleted the
fix/make-NEXT_PUBLIC_BUTTER_CMS_API_KEY-not-required
branch
karolkarolka
pushed a commit
that referenced
this pull request
Dec 17, 2024
karolkarolka
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it makes NEXT_PUBLIC_BUTTER_CMS_API_KEY env optional
Pull Request Checklist