Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PDP and search page improvements #110

Merged
merged 10 commits into from
Dec 19, 2024
Merged

feat: PDP and search page improvements #110

merged 10 commits into from
Dec 19, 2024

Conversation

soniaklimas
Copy link
Contributor

I want to merge this change because it copies PDP improvements from fashion branch and adjust them to Nimara code.

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

@soniaklimas soniaklimas self-assigned this Dec 12, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:42pm
nimara-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 1:42pm

@soniaklimas soniaklimas changed the title feat: Bump React 19 to the stable release version (#106) feat: PDP improvements Dec 12, 2024
@soniaklimas soniaklimas removed the WIP label Dec 17, 2024
karolkarolka
karolkarolka requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@karolkarolka karolkarolka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the changes for search page so adjust the PR name, please.

apps/storefront/src/app/[locale]/(main)/products/[slug]/components/details-dropdown.tsx Outdated Show resolved Hide resolved
apps/storefront/src/app/[locale]/(main)/products/[slug]/components/attributes-dropdown.tsx Outdated Show resolved Hide resolved
apps/storefront/src/app/[locale]/(main)/products/[slug]/components/product-display.tsx Outdated Show resolved Hide resolved
apps/storefront/src/app/[locale]/(main)/products/[slug]/components/product-display.tsx Outdated Show resolved Hide resolved
packages/domain/src/objects/Product.ts Outdated Show resolved Hide resolved
packages/ui/src/components/alert.tsx Outdated Show resolved Hide resolved
apps/storefront/src/app/[locale]/(main)/products/[slug]/components/variant-selector-utils.ts Outdated Show resolved Hide resolved
@soniaklimas soniaklimas changed the title feat: PDP improvements feat: PDP and search page improvements Dec 18, 2024
@soniaklimas soniaklimas merged commit 80eee2a into develop Dec 19, 2024
4 checks passed
@soniaklimas soniaklimas deleted the MS-865-pdp-improvements branch December 19, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karolkarolka karolkarolka karolkarolka approved these changes

Assignees

@soniaklimas soniaklimas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soniaklimas @karolkarolka