refactor: Copy and refactor nav #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karolkarolka
requested changes
Dec 10, 2024
apps/storefront/src/app/[locale]/(main)/_components/navigation.tsx
Outdated
Show resolved
Hide resolved
apps/storefront/src/app/[locale]/(main)/_components/navigation.tsx
Outdated
Show resolved
Hide resolved
apps/storefront/src/app/[locale]/(main)/_components/navigation.tsx
Outdated
Show resolved
Hide resolved
apps/storefront/src/app/[locale]/(main)/_components/navigation.tsx
Outdated
Show resolved
Hide resolved
| child.collection_slug ? { slug: child.collection_slug } : null, | ||
| child.page_slug ? { slug: child.page_slug } : null, | ||
| ) || | ||
| "#", |
There was a problem hiding this comment.
It needs to be string to use it as a href in Link, but url from cms can be null.
There was a problem hiding this comment.
Yeah but all of the elements in the menu should be links so if someone won't set links via CMS the storefront should be notified so either make URLs as required fields in types or make a condition item.url && <Link. Setting the hash as the link value when it wasn't set in CMS doesn't seem right to me. The empty hash will navigate to the top of the page and be weirdly visible in URL
packages/infrastructure/src/public/butter-cms/cms-menu/infrastructure/cms-menu-get-infra.ts
Outdated
Show resolved
Hide resolved
apps/storefront/src/app/[locale]/(main)/_components/navigation.tsx
Outdated
Show resolved
Hide resolved
karolkarolka
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it copies nav from fashion branch and refactores it.
Pull Request Checklist