Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DynamoDBCacheBackend to handle floats #42

Merged
merged 9 commits into from
Oct 13, 2023
Merged

Conversation

mat-sop
Copy link
Contributor

@mat-sop mat-sop commented Oct 12, 2023

This pr changes DynamoDBCacheBackend to serialize cached values as json strings

resolves #40

@mat-sop mat-sop self-assigned this Oct 12, 2023
@mat-sop mat-sop requested a review from rafalp October 12, 2023 09:58
@rafalp
Copy link
Contributor

rafalp commented Oct 12, 2023

This is a quick solution to the problem but we need to provide a way for developers to customize serialization/deserialization of values themselves, eg. to use faster JSON serializers or custom serialization logic.

ariadne_graphql_proxy/cache/serializer.py Outdated Show resolved Hide resolved
ariadne_graphql_proxy/cache/serializer.py Outdated Show resolved Hide resolved
ariadne_graphql_proxy/cache/serializer.py Outdated Show resolved Hide resolved
ariadne_graphql_proxy/cache/serializer.py Outdated Show resolved Hide resolved
ariadne_graphql_proxy/cache/serializer.py Outdated Show resolved Hide resolved
@mat-sop mat-sop requested a review from rafalp October 12, 2023 15:13
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Rafał Pitoń <[email protected]>
@mat-sop mat-sop merged commit acad887 into main Oct 13, 2023
2 checks passed
@mat-sop mat-sop deleted the dynamodb_floats branch October 13, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDBCacheBackend raises error when cache value includes floats
2 participants