Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create invidious.io #18

Merged
merged 12 commits into from
Sep 24, 2023
Merged

Create invidious.io #18

merged 12 commits into from
Sep 24, 2023

Conversation

OshekharO
Copy link
Member

@OshekharO OshekharO commented Aug 28, 2023

Audio and video both are seperated since there is no option for audio tracks , I don't know how to add it also subtitle are not able to open. You can merge if video only is not an issue.

Api docs with json schema for stream api: https://piped-docs.kavin.rocks/docs/api-documentation/

@MiaoMint
Copy link
Member

I didn't think about the split track at first

@MiaoMint
Copy link
Member

Try miru-project/miru-app#72

audioTrack field

@OshekharO
Copy link
Member Author

OshekharO commented Sep 21, 2023

Try miru-project/miru-app#72

audioTrack field

Screenshot_2023-09-21-08-51-21-27_724c77a6924735f59ad9bef5bae520c3

No option for audio track in player, tried latest build

@MiaoMint
Copy link
Member

The type of audioTrack is string

@OshekharO
Copy link
Member Author

OshekharO commented Sep 21, 2023

The type of audioTrack is string

Have tried this still not working showing type error not a function at watch

audioTrack: res.audioStreams[0].map((item) => item.url),

This also not working

audioTrack: res.audioStreams[0]?.url || "",

@MiaoMint
Copy link
Member

image
I can't open the video.

@OshekharO
Copy link
Member Author

image I can't open the video.

Go back and open again it will work

@MiaoMint
Copy link
Member

The type of audioTrack is string

Have tried this still not working showing type error not a function at watch

audioTrack: res.audioStreams[0].map((item) => item.url),

This also not working

audioTrack: res.audioStreams[0]?.url || "",

In the latest commit, my test has been working normally, but this extension always needs to be opened multiple times, otherwise access will fail.

@OshekharO
Copy link
Member Author

OshekharO commented Sep 24, 2023

audioTrack field will be

audioTrack: res.audioStreams?.[0]?.url,

right?

@MiaoMint
Copy link
Member

audioTrack field will be

audioTrack: res.audioStreams?.[0]?.url,

right? Or below one?

const track = res.audioStreams.map((item) => ({ title: item.format, url: item.url, language: item.quality, }));

Just one, type is string

Still getting some tcp error and buffer issue after audio track addition
@MiaoMint
Copy link
Member

It should work fine, right?

Api changed so no more buffer
@OshekharO
Copy link
Member Author

LGTM

@MiaoMint MiaoMint merged commit b1839a4 into miru-project:main Sep 24, 2023
1 check passed
@OshekharO OshekharO deleted the patch-3 branch September 24, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants