Update to Mirage 4.5.0 #192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With mirage/ocaml-solo5#135 using |
|
Will be included in #178 . |
hannesm
reviewed
Apr 23, 2024
hannesm
reviewed
Apr 23, 2024
| package "mirage-logs"; | ||
| package "mirage-xen" ~min:"8.0.0"; | ||
| package ~min:"6.4.0" "dns-client"; | ||
| package "dns-client" ~min:"6.4.0"; | ||
| package "pf-qubes"; |
There was a problem hiding this comment.
are these argument reorderings needed?
There was a problem hiding this comment.
I don't think it needed, this was just cosmetic to keep packages aligned.
hannesm
reviewed
Apr 23, 2024
|
Sorry I closed while you are reviewing it, I'll add your changes in #178. |
|
@palainp thanks. no worries. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear devs,
This PR wants to update to recent mirage API. In doing so it appears that
Memory.quick_stat()reports wrong values (I haven't investigated why yet, and maybe it was present before, but now it goes lower than the limits inEDIT: There was a bad computation inmemory_pressure.mlocaml-solo5again):With wrong values, the firewall starts to drop packets (Memory_criticalbeing returned byMemory_pressure.status()). So I've replacedMemory.quick_stat()withMemory.stat(), but this is at the cost of going through the whole heap andMemory_pressure.statuscalls it for each packets. But I'd rather the firewall be slower than unusable :)Going further will need to dive more intoocaml-solo5/nolibc/malloc.ias the bug seems to come from there but the code is really hard :'(Best,