Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update unikernel to recent mirage #522

Merged
merged 2 commits into from
Aug 8, 2024
Merged

update unikernel to recent mirage #522

merged 2 commits into from
Aug 8, 2024

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Aug 5, 2024

No description provided.

@hannesm
Copy link
Member Author

hannesm commented Aug 5, 2024

The issue is that tcpip is pinned to tcpip.dev, while mirage requires it to be >= 7.0.0 & < 9.0.0... Is there any support in setup-ocaml to pin packages to a specific version @smorimoto?

@smorimoto
Copy link
Contributor

In this case, just pass false to the opam-pin input is enough!

@hannesm
Copy link
Member Author

hannesm commented Aug 6, 2024

In this case, just pass false to the opam-pin input is enough!

Thanks for your quick reply, unfortunately I don't quite understand where in the main.yml a false needs to be passed. Could you provide me with some hint?

@reynir
Copy link
Member

reynir commented Aug 8, 2024

I found in https://github.com/ocaml/setup-ocaml/?tab=readme-ov-file#inputs the ocaml-compiler option next to the opam-pin option and did pattern matching (qualified guess) to figure out where to add it. Let's see if it works. I hope I am not stepping on anyone's toes by pushing this commit.

@hannesm hannesm merged commit f03cd0d into mirage:main Aug 8, 2024
8 checks passed
@hannesm
Copy link
Member Author

hannesm commented Aug 8, 2024

Thanks a lot, merging... CI is green :)

@hannesm hannesm deleted the fix-ci branch August 8, 2024 10:58
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Aug 22, 2024
CHANGES:

* Use `mirage-crypto.1.0` & `randomconv.0.2` (@hannesm, mirage/mirage-tcpip#521)
* Update unikernels to `mirage.4.6.0` (@hannesm, @reynir, @smorimoto, mirage/mirage-tcpip#522)
* Update our CI system (@samoht, @smorimoto, mirage/mirage-tcpip#519, mirage/mirage-tcpip#520)
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
CHANGES:

* Use `mirage-crypto.1.0` & `randomconv.0.2` (@hannesm, mirage/mirage-tcpip#521)
* Update unikernels to `mirage.4.6.0` (@hannesm, @reynir, @smorimoto, mirage/mirage-tcpip#522)
* Update our CI system (@samoht, @smorimoto, mirage/mirage-tcpip#519, mirage/mirage-tcpip#520)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants