Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency urllib3 to v2.0.7 [security] #151

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 17, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
urllib3 (changelog) ==2.0.6 -> ==2.0.7 age adoption passing confidence

Warning

Some dependencies could not be looked up. Check the warning logs for more information.

GitHub Vulnerability Alerts

CVE-2023-45803

urllib3 previously wouldn't remove the HTTP request body when an HTTP redirect response using status 303 "See Other" after the request had its method changed from one that could accept a request body (like POST) to GET as is required by HTTP RFCs. Although the behavior of removing the request body is not specified in the section for redirects, it can be inferred by piecing together information from different sections and we have observed the behavior in other major HTTP client implementations like curl and web browsers.

From RFC 9110 Section 9.3.1:

A client SHOULD NOT generate content in a GET request unless it is made directly to an origin server that has previously indicated, in or out of band, that such a request has a purpose and will be adequately supported.

Affected usages

Because the vulnerability requires a previously trusted service to become compromised in order to have an impact on confidentiality we believe the exploitability of this vulnerability is low. Additionally, many users aren't putting sensitive data in HTTP request bodies, if this is the case then this vulnerability isn't exploitable.

Both of the following conditions must be true to be affected by this vulnerability:

  • If you're using urllib3 and submitting sensitive information in the HTTP request body (such as form data or JSON)
  • The origin service is compromised and starts redirecting using 303 to a malicious peer or the redirected-to service becomes compromised.

Remediation

You can remediate this vulnerability with any of the following steps:

  • Upgrade to a patched version of urllib3 (v1.26.18 or v2.0.7)
  • Disable redirects for services that you aren't expecting to respond with redirects with redirects=False.
  • Disable automatic redirects with redirects=False and handle 303 redirects manually by stripping the HTTP request body.

Release Notes

urllib3/urllib3 (urllib3)

v2.0.7

Compare Source

  • Made body stripped from HTTP requests changing the request method to GET after HTTP 303 "See Other" redirect responses. (GHSA-g4mx-q9vg-27p4)

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 18 0 0.54s
✅ BASH bash-exec 4 0 0.03s
✅ BASH shellcheck 1 0 0.03s
✅ BASH shfmt 4 0 0.03s
⚠️ CSHARP csharpier 1 1 0.4s
⚠️ CSHARP dotnet-format 1 1 1.85s
✅ CSS stylelint 1 0 2.19s
✅ DOCKERFILE hadolint 4 0 0.27s
✅ EDITORCONFIG editorconfig-checker 374 0 3.45s
✅ ENV dotenv-linter 1 0 0.02s
✅ GROOVY npm-groovy-lint 7 0 14.49s
✅ HTML djlint 2 0 0.9s
✅ HTML htmlhint 2 0 0.38s
✅ JAVA checkstyle 59 0 7.69s
✅ JSON eslint-plugin-jsonc 29 0 7.08s
✅ JSON jsonlint 29 0 0.34s
✅ JSON prettier 29 0 4.81s
✅ JSON v8r 29 0 42.54s
⚠️ MARKDOWN markdownlint 22 117 1.82s
✅ PYTHON bandit 1 0 1.31s
✅ PYTHON black 1 0 0.85s
✅ PYTHON flake8 1 0 0.76s
✅ PYTHON isort 1 0 0.45s
✅ PYTHON mypy 1 0 7.36s
✅ PYTHON ruff 1 0 0.08s
✅ REPOSITORY checkov yes no 30.11s
✅ REPOSITORY gitleaks yes no 1.6s
✅ REPOSITORY git_diff yes no 0.12s
✅ REPOSITORY grype yes no 14.12s
✅ REPOSITORY kics yes no 89.77s
✅ REPOSITORY secretlint yes no 2.27s
✅ REPOSITORY syft yes no 1.32s
✅ REPOSITORY trivy yes no 25.07s
✅ REPOSITORY trivy-sbom yes no 2.22s
✅ REPOSITORY trufflehog yes no 9.48s
✅ SQL sql-lint 2 0 0.98s
✅ XML xmllint 3 0 0.03s
✅ YAML prettier 109 0 3.06s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

@renovate renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch 2 times, most recently from 1c10653 to d8ce556 Compare November 1, 2023 17:35
@renovate renovate bot force-pushed the renovate/pypi-urllib3-vulnerability branch from d8ce556 to ccb8964 Compare November 1, 2023 18:32
@chgl chgl merged commit 746840c into master Nov 1, 2023
25 checks passed
@miracum-bot miracum-bot mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant