Skip to content

Commit

Permalink
Updated the lints for Flutter 3.19 and metrics 5.7.6 (#20)
Browse files Browse the repository at this point in the history
* Updated FVM config
Updated Flutter version

* Updated project dependencies

* Updated the package to Flutter 3.19
  • Loading branch information
PiotrMitkowski authored Jul 1, 2024
1 parent c10c967 commit b2849ce
Show file tree
Hide file tree
Showing 8 changed files with 39 additions and 9 deletions.
4 changes: 4 additions & 0 deletions .fvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"flutter": "3.19.6",
"flavors": {}
}
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,6 @@ pubspec.lock
.dart_tool
.packages
build/

# FVM Version Cache
.fvm/
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"dart.flutterSdkPath": ".fvm/versions/3.19.6"
}
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,24 @@
## 1.19.0

* Lints from dart_metrics version 5.7.6
* Lints for Flutter 3.19.6 and Dart 3.3.4
* Added separate lints config for Flutter & Dart packages
* :warning: This version is based on discontinued DCM version

## 1.16.0

* Lints from dart_metrics version 5.7.6
* Lints for Flutter 3.16.2 and Dart 3.2.2
* :warning: This version is based on discontinued DCM version

## 1.13.2

* Lints from dart_metrics version 5.7.6
* Lints for Flutter 3.13.0 and Dart 3.0.6
* :warning: This version is based on discontinued DCM version

## 1.10.0

* Lints from dart_metrics version 5.7.3
* Lints for Flutter 3.10.0 and Dart 3.0.0
* Removed `implicit-casts` and `implicit-dynamic` rules deprecated in Dart 3
Expand Down
6 changes: 3 additions & 3 deletions example/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: lint_quido_example
version: 1.16.0
version: 1.19.0
publish_to: none

environment:
sdk: ">=3.2.2 <4.0.0"
flutter: ">=3.16.2"
sdk: ">=3.3.0 <4.0.0"
flutter: ">=3.19.6"

dependencies:
lint_quido:
Expand Down
6 changes: 3 additions & 3 deletions lib/miquido_lints.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ linter:
- always_declare_return_types
- always_put_control_body_on_new_line
- always_put_required_named_parameters_first
- always_require_non_null_named_parameters
# - always_specify_types - Incompatible with avoid_types_on_closure_parameters, which we prefer
- always_use_package_imports
- annotate_overrides
Expand Down Expand Up @@ -56,8 +55,6 @@ linter:
- avoid_relative_lib_imports
- avoid_renaming_method_parameters
- avoid_return_types_on_setters
- avoid_returning_null
- avoid_returning_null_for_future
- avoid_returning_null_for_void
- avoid_returning_this
- avoid_setters_without_getters
Expand Down Expand Up @@ -114,6 +111,7 @@ linter:
# - lines_longer_than_80_chars - In Miquido there are two teams: 100 or 120. One of them is wrong.
- literal_only_boolean_expressions
- matching_super_parameters
# - missing_code_block_language_in_doc_comment - currently experimental and not yet available in a stable SDK.
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_default_cases
Expand Down Expand Up @@ -195,6 +193,7 @@ linter:
- type_init_formals
- type_literal_in_constant_pattern
- unawaited_futures
# - unintended_html_in_doc_comment - currently experimental and not yet available in a stable SDK.
- unnecessary_await_in_return
- unnecessary_brace_in_string_interps
- unnecessary_breaks
Expand All @@ -205,6 +204,7 @@ linter:
- unnecessary_lambdas
- unnecessary_late
- unnecessary_library_directive
# - unnecessary_library_name - currently experimental and not yet available in a stable SDK.
- unnecessary_new
- unnecessary_null_aware_assignments
- unnecessary_null_aware_operator_on_extension_on_nullable
Expand Down
10 changes: 10 additions & 0 deletions lib/miquido_package_lints.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# This set of lints builds on top of `package:lints/core.yaml`.
# It includes lints dedicated to the Flutter and Dart packages.

include: package:lint_quido/miquido_lints.yaml

linter:
rules:
always_use_package_imports: false
prefer_relative_imports: true
public_member_api_docs: true
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: lint_quido
version: 1.16.0
version: 1.19.0
description: Collection of Flutter lints that we use and follow in Miquido
repository: https://github.com/miquido/lint_quido
issue_tracker: https://github.com/miquido/lint_quido/issues
Expand All @@ -11,8 +11,8 @@ topics:
- lints

environment:
sdk: ">=3.2.2 <4.0.0"
flutter: ">=3.16.2"
sdk: ">=3.3.4 <4.0.0"
flutter: ">=3.19.6"

platforms:
android:
Expand Down

0 comments on commit b2849ce

Please sign in to comment.