Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSDP boefje to find devices inside of a network #3594

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Souf149
Copy link
Contributor

@Souf149 Souf149 commented Sep 27, 2024

Changes

Add a SSDP boefje that scans for machines / services on local networks. A perfect example of a boefje that might need #3299 as a feature.

Demo

image

image

QA notes

To simulate a SDDP server I did the following:

  1. I ran docker compose exec -it boefje bash
  2. Inside of this shell I then install ssdpy with pip install ssdpy
  3. And then run python3 -c 'from ssdpy import SSDPServer;SSDPServer("cynalytics-server",proto="ipv4", device_type="my_device_type",location="http://145.131.253.241:8000/en/cyn/").serve_forever()' to start a sddp server inside of the boefje container.

Additional note

Code inside boefjes/boefjes/plugins/kat_ssdp/main.py needs to have the import statement moved to the top of the file, but because of #3582 this is not possible.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Souf149 Souf149 requested a review from a team as a code owner September 27, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant