Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update presentations controller logic and spec #315

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

experimatt
Copy link
Contributor

This is a follow up to #305, which broke the controller tests.

This allows for both :id and :name params to be passed into the controller. When a presenter is found, an :id is passed, but if the user hits enter with just a text string search, we still need to handle that case, hence why :name is still permitted.

@experimatt experimatt requested a review from unsay June 9, 2024 18:43
@pcantrell pcantrell merged commit a590e3f into master Jun 9, 2024
1 check passed
@unsay unsay deleted the mdecuir/fix-presentations-controller-tests branch June 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants