Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip "testDragDropOntoHiddenItself" test on Selenium 2 + Firefox #401

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Nov 11, 2024

Closes #391

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (867a928) to head (d9ab42a).
Report is 29 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
- Coverage     90.52%   86.20%   -4.32%     
- Complexity      180      193      +13     
============================================
  Files             1        1              
  Lines           517      551      +34     
============================================
+ Hits            468      475       +7     
- Misses           49       76      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 force-pushed the selenium2-self-drag-test-exclusion branch from 5b6a608 to 9a84262 Compare November 11, 2024 10:36
@aik099 aik099 requested a review from uuf6429 November 12, 2024 08:05
tests/Selenium2Config.php Outdated Show resolved Hide resolved
@uuf6429
Copy link
Member

uuf6429 commented Nov 12, 2024

Other than the two minor comments I left, what about that failing build? I haven't investigated it, but at first look it doesn't sound random.

Copy link
Member

@uuf6429 uuf6429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the failing test, this looks fine to me.

@aik099 aik099 merged commit d9df3d5 into minkphp:master Nov 12, 2024
10 of 12 checks passed
@aik099 aik099 deleted the selenium2-self-drag-test-exclusion branch November 12, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use latest Firefox version with Selenium 2 on GitHub Actions
2 participants