Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementing pressKey #305

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

implementing pressKey #305

wants to merge 4 commits into from

Conversation

oleg-andreyev
Copy link
Contributor

  • implementing pressKey
  • bumped behat/mink to 1.8@dev

@oleg-andreyev
Copy link
Contributor Author

minkphp/Mink#772

@oleg-andreyev
Copy link
Contributor Author

@stof @aik099 ready for review.
this probably will be a bit harder because need to sync changes across 3 repos: Mink, Testsuite and this repo. I've added "TO BE REVERTED" message to commits that should be reverted before merging into master. They are required to ensure that tests are passing.

@aik099
Copy link
Member

aik099 commented Sep 2, 2019

@oleg-andreyev please in every of 3 PRs list other associated PRs in order of their merging.

@oleg-andreyev
Copy link
Contributor Author

minkphp/Mink#772
minkphp/driver-testsuite#30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleg-andreyev @aik099