Remove spans from within editable elements #399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispymm
changed the title
chrispymm
force-pushed
the
revert-editable-element-spans
branch
from
a1ecef0 to
cf60453
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR walks back the changes I made last week adding child spans to all editable headings to keep the semantics.
A similar issue affected the editbale label elements for checkboxes and radios, however we are not easily able to add child spans into the labels as they are generated using GovukFormbuilder gem.
In order to solve both problems, we will remove the child and instead modify the editor JS to insert them.