Skip to content

Commit

Permalink
fix: removed unused dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
Kaizen-7 committed Jan 11, 2022
1 parent 25e1687 commit d0c3a63
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,6 @@ dependencies {
implementation Deps.gson_converter

testImplementation Deps.test_junit
testImplementation Deps.test_mockk
testImplementation Deps.androidx_core_testing
testImplementation Deps.test_coroutines
}

2 changes: 1 addition & 1 deletion buildSrc/src/main/java/Dependencies.kt
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ object Deps {
const val tools_kotlin = "org.jetbrains.kotlin:kotlin-gradle-plugin:${Versions.kotlin}"
const val desugar_jdk_libs = "com.android.tools:desugar_jdk_libs:${Versions.desugar_jdk_libs}"
const val test_junit = "junit:junit:${Versions.junit}"
const val test_mockk = "io.mockk:mockk-android:${Versions.mockk}"
const val test_mockk = "io.mockk:mockk:${Versions.mockk}"

This comment has been minimized.

Copy link
@rawmain

rawmain Jan 11, 2022

Hello @Kaizen-7

Owing to minSdk declaration, this edit (line 43) for test_mockk dependency triggers the following error :

MethodHandle.invoke and MethodHandle.invokeExact are only supported starting with Android O (--min-api 26)

No issues instead by reverting to

const val test_mockk = "io.mockk:mockk-android:${Versions.mockk}"

This comment has been minimized.

Copy link
@Kaizen-7

Kaizen-7 Jan 11, 2022

Author

you shouldn't get any error if you align your SDK to my last commit in ministero-salute/it-dgc-verificac19-sdk-android#106, it seems to be a problem related to duplicated dependencies in SDK Gradle file, when I revert this line as you suggested I've got another error that said to remove the "android" part, so let me know if it works with my latest commit

This comment has been minimized.

Copy link
@rawmain

rawmain Jan 11, 2022

Thanks @Kaizen-7

Just rebuilt with :

  • develop + refactor/update-dependencies commits for whitelabel-app (so using again mockk - instead of mockk-android - for dependency name).

  • current develop branch for DGC-SDK (after PR106 merge)

No build/runtime issues so far - neither with dgc-sdk nor with app.



const val kotlinx_coroutines = "org.jetbrains.kotlinx:kotlinx-coroutines-android:${Versions.kotlinx_coroutines}"
Expand Down

0 comments on commit d0c3a63

Please sign in to comment.