Remove eye offsetting hacks #2918
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK for beds. But for carts it looks like you're flying in 1st person view even though the model is positioned sanely in 3rd person. |
Hmm, carts are weird - while the model is standing, the eye offset is supposed to be that of a sitting player? I suspect this is to partially work around #1927. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eye height is now managed by player_api and automatically reduced when the sitting or laying animations are set. The resetting of eye height in beds was entirely unneeded and only had potential to break mods. For carts, this fixes the eye height being too low.