Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lightbulbs buildable to #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wsor4035
Copy link

what the description says, handy for building with them (good source of hidden light for builds)

@Calinou
Copy link
Member

Calinou commented Jan 23, 2021

I'm not sure if this is a good idea – I made light bulbs non-buildable-to to prevent griefing. Since Map Tools nodes are only meant to be used by administrators, it's important that regular players can't mess with them.

Of course, this doesn't affect you if you use a protection mod, but this may not always be the case for everyone.

@wsor4035
Copy link
Author

understandable, but most servers use a protection mod. i modified this because while you can //r air lightbulb with worldedit when your done, but adding light and able to modify it while building is nice

@Calinou
Copy link
Member

Calinou commented Jan 23, 2021

I think a better solution to this would be to add a minetest.conf setting that makes all non-solid Map Tools nodes buildable to. You can then enable this setting if you use a protection mod on the server. The setting should be disabled by default to keep backwards compatibility – I don't want to see some servers' spawn areas ruined by this change 🙂

@wsor4035
Copy link
Author

wsor4035 commented Jan 23, 2021

does it need to be a setting or if(protection_mod) then... ?

@Calinou
Copy link
Member

Calinou commented Jan 23, 2021

does it need to be a setting or if(protection_mod) then... ?

It needs to be added as a setting and the setting must be used in the Lua code to set the value of buildable_to at registration time. See minetest-mods/moreblocks for an example of this (specifically, settingtypes.txt and nodes.lua).

@wsor4035
Copy link
Author

I know how to do settings, that was NOT what I asked, to clarify:
instead of a setting, should it be auto enabled when areas is detected?
or it could be both, setting, thats default depends on if areas is installed or not

@Calinou
Copy link
Member

Calinou commented Jan 23, 2021

instead of a setting, should it be auto enabled when areas is detected?

I think it should be a setting, as there are many protection mods and not all of them are called areas. Explicit is better than implicit 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants