Refactor table join logic in DBCommandClass.php

mindstellar · Apr 23, 2024 · dcb37b7 · dcb37b7
1 parent 99e39e2
commit dcb37b7
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/oc-includes/osclass/classes/database/DBCommandClass.php b/oc-includes/osclass/classes/database/DBCommandClass.php
@@ -1335,7 +1335,13 @@ public function _getSelect()
             if (!is_array($this->aFrom)) {
                 $this->a_from = array($this->aFrom);
             }
-            $sql .= implode(', ', $this->aFrom);
+            // instead of comma separated tables, we use cross join
+            // , is same as CROSS JOIN in this case
+            if (count($this->aFrom) > 1) {
+                $sql .= implode(' CROSS JOIN ', $this->aFrom);
+            } else {
+                $sql .= implode(', ', $this->aFrom);
+            }
         }
 
         // "JOIN" portion of the query