patching: instantmesh/sv3d conversion tests #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaFred
requested review from
vigo999,
CaitinZhao,
SamitHuang and
zhanghuiyao
as code owners
|
Update: This effect turns out to be true for windows python env, not for other unix env like linux/mac os. There are some other files being affected, including but not limited to： |
HaFred
changed the title
HaFred
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flake8 by default checks whether there are spaces after symbols (in E231), which may be wrong from time to time for the cases below.
https://This pr fixes it, and also with some refactors for conversion tests. Without this PR, some existing code will be identified as incorrect:
examples/latte/sample.pyexamples/sv3d/train.py