Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the library #33

Merged
merged 4 commits into from
May 6, 2024
Merged

Improve the library #33

merged 4 commits into from
May 6, 2024

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented May 6, 2024

@mindplay-dk I've decided to put all things in one PR.

  1. Stop distributing development files: git archive HEAD|tar --list
  2. Fix typos
  3. 1 Composer script/1 CI step
  4. Fix gitignores: git ls-files --cached --ignored --exclude-standard
  5. Move the logo to .github/

the theory

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
@mindplay-dk mindplay-dk merged commit a952b00 into mindplay-dk:master May 6, 2024
4 of 5 checks passed
@mindplay-dk
Copy link
Owner

@szepeviktor do you know if, instead of this:

.github/ export-ignore
.gitattributes export-ignore
.gitignore export-ignore
.scrutinizer.yml export-ignore

can we just do:

.* export-ignore

(same as in the .gitignore.)

@szepeviktor
Copy link
Contributor Author

can we just do:

.* export-ignore

I do not dare to jump into an empty pool.

Explicit Viktor 🙃

@szepeviktor szepeviktor deleted the improve branch May 6, 2024 16:28
@szepeviktor
Copy link
Contributor Author

Glad to contribute.

@szepeviktor
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants