Add project id foreign key to data sources tables. #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables `data_sources_functions` and `rule_type_data_sources` added by migration 108 lacked a reference to their containing project. This change adds `project_id` foreign key in the style of `rule_instances` in order to avoid future mistakes like exposing resouces by id to users that don't have rights on the containing project.
JAORMX
approved these changes
Nov 22, 2024
teodor-yanev
approved these changes
Nov 22, 2024
Comment on lines
+26
to
+33
| BEGIN | ||
| FOR ds_id, pj_id IN SELECT id, project_id FROM data_sources | ||
| LOOP | ||
| UPDATE data_sources_functions | ||
| SET project_id = pj_id | ||
| WHERE data_source_id = ds_id; | ||
| END LOOP; | ||
| END $$; |
There was a problem hiding this comment.
Could this and the loop below be optimised using a JOIN?
e.g.:
UPDATE data_sources_functions dsf
SET project_id = ds.project_id
FROM data_sources ds
WHERE dsf.data_source_id = ds.id;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tables
data_sources_functionsandrule_type_data_sourcesadded by migration 108 lacked a reference to their containing project.This change adds
project_idforeign key in the style ofrule_instancesin order to avoid future mistakes like exposing resouces by id to users that don't have rights on the containing project.Change Type
Testing
Manually ran
migrate upandmigrate downin a database containing a few records. The aim of the test was to verify that the calculated project id was correct.Review Checklist: