[FEAT] Asyncio support #2411
Merged
[FEAT] Asyncio support #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brcarry
commented
Dec 5, 2024
brcarry
commented
- Support async delete, get, insert, query, search, hybrid_search, upsert, create_collection, drop_collection, describe_collection
- Support adding interceptor to aio channel
- Retry checking connect state instead of channel_ready_future in connect_milvus
- Support async delete, get, insert, query, search, hybrid_search, upsert, create_collection, drop_collection, describe_collection - Support adding interceptor to aio channel - Retry checking connect state instead of channel_ready_future in connect_milvus Signed-off-by: Ruichen Bao <[email protected]>
|
/hold |
XuanYang-cn
requested changes
Dec 11, 2024
… "_async" check, optimize "_wait_for_channel_ready" - Refactor AsyncGrpcHandler to inherit GrpcHandler Class, enabling reuse of existing sync methods - Remove unnecessary "_async" check in async methods - Replace previous polling logic `_async_channel.get_state()` by `_async_channel.channel_ready()` in `_wait_for_channel_ready` Signed-off-by: Ruichen Bao <[email protected]>
- Provide only asynchronous interfaces in AsyncMilvusClient - Convert `_prepare_row/batch_insert/upsert_request`, `create_index`, and `load_collection` and their related functions to asynchronous implementations - Retain only functions being used in async_utility.py Signed-off-by: Ruichen Bao <[email protected]>
XuanYang-cn
requested changes
Dec 13, 2024
XuanYang-cn
requested changes
Dec 13, 2024
… for async client - Update `__init__.py` to allow importing AsyncMilvusClient - Add a simple code example for AsyncMilvusClient - Add the previously missing `_async_create_collection_with_schema` method Signed-off-by: Ruichen Bao <[email protected]>
Signed-off-by: Ruichen Bao <[email protected]>
- Add `_async` parameter in `connections.py` to determine whether to establish a synchronous or asynchronous connection - Fix `__all__` is not sorted in `__init__.py` which failed in code lint check Signed-off-by: Ruichen Bao <[email protected]>
XuanYang-cn
requested changes
Dec 16, 2024
- Rename `async_*` methods as `async def` already indicates this is an async method. For example: `async_create_collection` → `create_collection` - Add a class doc for `AsyncMilvusClient` - Remove commented-out code in example Signed-off-by: Ruichen Bao <[email protected]>
|
/approve |
|
/unhold |
XuanYang-cn
approved these changes
Dec 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brcarry, czs007, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.