Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add search iterator v2 #2395

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Nov 29, 2024

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Nov 29, 2024

/hold
wait for milvus PR milvus-io/milvus#37947 to be merged first

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically LGTM

But I have a compactibility concern: Collection.SearchIterator added a "use_v1 = False", new PyMilvus with old Milvus might raise Exceptions directly.

@czs007
Copy link
Contributor

czs007 commented Dec 23, 2024

@PwzXxm please add to MilvusClient.
DO NOT Add any logic to ORM any more.

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Dec 23, 2024

@PwzXxm please add to MilvusClient. DO NOT Add any logic to ORM any more.

Will do. Will let QA test on MilvusClient rather than ORM on this feature.

@PwzXxm PwzXxm force-pushed the search_iter_v2 branch 7 times, most recently from bf04252 to 53d01db Compare December 27, 2024 10:41
Signed-off-by: Patrick Weizhi Xu <[email protected]>
@PwzXxm
Copy link
Contributor Author

PwzXxm commented Dec 27, 2024

/unhold

pymilvus/client/search_iterator.py Outdated Show resolved Hide resolved
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PwzXxm, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 240133e into milvus-io:master Dec 30, 2024
11 checks passed
@XuanYang-cn XuanYang-cn added the PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x label Dec 30, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 30, 2024
pr: #2395
issue: milvus-io/milvus#37548

Signed-off-by: Patrick Weizhi Xu <[email protected]>
(cherry picked from commit 3ce4ac0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants