-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add search iterator v2 #2395
Conversation
/hold |
c152de9
to
315f38a
Compare
315f38a
to
6398b3a
Compare
6398b3a
to
058b42e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically LGTM
But I have a compactibility concern: Collection.SearchIterator added a "use_v1 = False", new PyMilvus with old Milvus might raise Exceptions directly.
058b42e
to
34c1887
Compare
@PwzXxm please add to MilvusClient. |
Will do. Will let QA test on MilvusClient rather than ORM on this feature. |
bf04252
to
53d01db
Compare
Signed-off-by: Patrick Weizhi Xu <[email protected]>
53d01db
to
3ce4ac0
Compare
/unhold |
Signed-off-by: Patrick Weizhi Xu <[email protected]>
4fc5dd2
to
0359222
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PwzXxm, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pr: #2395 issue: milvus-io/milvus#37548 Signed-off-by: Patrick Weizhi Xu <[email protected]> (cherry picked from commit 3ce4ac0)
issue: milvus-io/milvus#37548