Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: RBAC Custom Privilege Group API #2342

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

shaoting-huang
Copy link
Contributor

@sre-ci-robot
Copy link

Welcome @shaoting-huang! It looks like this is your first PR to milvus-io/pymilvus 🎉

@shaoting-huang shaoting-huang changed the title enhance: RBAC custom privilege group API enhance: RBAC Custom Privilege Group API Nov 13, 2024
@mergify mergify bot added the dco-passed label Nov 13, 2024
or error occur.

Returns:
List[str]: A list of all privilege groups and its privileges.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to distinguish privilege groups and its privileges from a sting list?

Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
@weiliu1031
Copy link
Contributor

/lgtm

@weiliu1031
Copy link
Contributor

/cc @XuanYang-cn

@XuanYang-cn
Copy link
Contributor

/unapprove
@shaoting-huang please fix the code checker

Signed-off-by: shaoting-huang <[email protected]>
@mergify mergify bot added the ci-passed label Nov 13, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Nov 13, 2024
@sre-ci-robot sre-ci-robot merged commit 5ec0a60 into milvus-io:master Nov 13, 2024
11 checks passed
@XuanYang-cn XuanYang-cn removed the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants